Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added Cloudflare R2 guide for Object Storage #10497

Merged
merged 18 commits into from
Jan 8, 2025
Merged

docs: added Cloudflare R2 guide for Object Storage #10497

merged 18 commits into from
Jan 8, 2025

Conversation

ehtisham-afzal
Copy link
Contributor

No description provided.

@ehtisham-afzal ehtisham-afzal requested a review from a team as a code owner December 8, 2024 16:10
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3bd2865

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 8, 2024 4:11pm

@vercel Vercel
Copy link

vercel bot commented Dec 8, 2024

@ehtisham-afzal is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@ogcatt
Copy link

ogcatt commented Dec 13, 2024 •
edited
Loading

I receive this error when following your guide: Credential access key has length 40, should be 32

@ehtisham-afzal
Copy link
Contributor Author

I receive this error when following your guide: Credential access key has length 40, should be 32

can you share the example of your credentials you're using

shahednasser
shahednasser requested changes Dec 31, 2024
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

www/apps/resources/app/architectural-modules/file/s3/page.mdx Outdated Show resolved Hide resolved
www/apps/resources/app/architectural-modules/file/s3/page.mdx Outdated Show resolved Hide resolved
www/apps/resources/app/architectural-modules/file/s3/page.mdx Outdated Show resolved Hide resolved
www/apps/resources/app/architectural-modules/file/s3/page.mdx Outdated Show resolved Hide resolved
www/apps/resources/app/architectural-modules/file/s3/page.mdx Outdated Show resolved Hide resolved
www/apps/resources/app/architectural-modules/file/s3/page.mdx Outdated Show resolved Hide resolved
www/apps/resources/app/architectural-modules/file/s3/page.mdx Outdated Show resolved Hide resolved
www/apps/resources/app/architectural-modules/file/s3/page.mdx Outdated Show resolved Hide resolved
www/apps/resources/app/architectural-modules/file/s3/page.mdx Outdated Show resolved Hide resolved
www/apps/resources/app/architectural-modules/file/s3/page.mdx Outdated Show resolved Hide resolved
@shahednasser shahednasser changed the title Added Cloudflare R2 guide for Object Storage docs: added Cloudflare R2 guide for Object Storage Dec 31, 2024
ehtisham-afzal and others added 12 commits December 31, 2024 07:34
@ehtisham-afzal @shahednasser
Update www/apps/resources/app/architectural-modules/file/s3/page.mdx
eef9cf8 
Co-authored-by: Shahed Nasser <[email protected]>
@ehtisham-afzal @shahednasser
Update www/apps/resources/app/architectural-modules/file/s3/page.mdx
f15bb01 
Co-authored-by: Shahed Nasser <[email protected]>
@ehtisham-afzal @shahednasser
Update www/apps/resources/app/architectural-modules/file/s3/page.mdx
4bca599 
Co-authored-by: Shahed Nasser <[email protected]>
@ehtisham-afzal @shahednasser
Update www/apps/resources/app/architectural-modules/file/s3/page.mdx
83838c6 
Co-authored-by: Shahed Nasser <[email protected]>
@ehtisham-afzal @shahednasser
Update www/apps/resources/app/architectural-modules/file/s3/page.mdx
33e3898 
Co-authored-by: Shahed Nasser <[email protected]>
@ehtisham-afzal @shahednasser
Update www/apps/resources/app/architectural-modules/file/s3/page.mdx
f3def28 
Co-authored-by: Shahed Nasser <[email protected]>
@ehtisham-afzal @shahednasser
Update www/apps/resources/app/architectural-modules/file/s3/page.mdx
57e7bef 
Co-authored-by: Shahed Nasser <[email protected]>
@ehtisham-afzal @shahednasser
Update www/apps/resources/app/architectural-modules/file/s3/page.mdx
34e76b3 
Co-authored-by: Shahed Nasser <[email protected]>
@ehtisham-afzal
Merge branch 'develop' into sham
089ee4e
@ehtisham-afzal @shahednasser
Update www/apps/resources/app/architectural-modules/file/s3/page.mdx
cbad88f 
Co-authored-by: Shahed Nasser <[email protected]>
@ehtisham-afzal @shahednasser
Update www/apps/resources/app/architectural-modules/file/s3/page.mdx
3350e2f 
Co-authored-by: Shahed Nasser <[email protected]>
@ehtisham-afzal @shahednasser
Update www/apps/resources/app/architectural-modules/file/s3/page.mdx
6b83e72 
Co-authored-by: Shahed Nasser <[email protected]>
shahednasser
shahednasser requested changes Jan 2, 2025
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you marked some comments as resolved when you didn't address them. I unresolved them, can you fix them?

@ehtisham-afzal
Copy link
Contributor Author

I see you marked some comments as resolved when you didn't address them. I unresolved them, can you fix them?

I reviewed the changes and its correct and updated with your suggestions

image

shahednasser
shahednasser requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are three comments that you seem to be missing so I'll add the link to them:

If it's still unclear, please let me know

shahednasser
shahednasser approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 2734dd6 into medusajs:develop Jan 8, 2025
23 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahednasser shahednasser shahednasser approved these changes

Assignees
No one assigned
Labels
automerge type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehtisham-afzal @ogcatt @shahednasser